Skip to content

Normalise use of Never vs NoReturn #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 17, 2022
Merged

Normalise use of Never vs NoReturn #8549

merged 4 commits into from
Aug 17, 2022

Conversation

AlexWaygood
Copy link
Member

hauntsaninja
hauntsaninja approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming that you don't need to explicitly use typing_extensions.Never in typing.py

@AlexWaygood
Copy link
Member Author

Looks good, assuming that you don't need to explicitly use typing_extensions.Never in typing.py

Looks like I do :)

AlexWaygood
AlexWaygood commented Aug 17, 2022
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
3 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 2c05265 into master Aug 17, 2022
@AlexWaygood AlexWaygood deleted the never branch August 17, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @hauntsaninja