Stdlib: fix three trivial issues with parameter defaults #9618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9608.
_dummy_threading.stack_size: thesizeparameter can beNone, and the default isNonegettext.find: the default value for theallparameter isFalse, so the= ...for theallparameter in theLiteral[True]overload is incorrect. We only want type checkers to select theLiteral[True]overload(s) if the user has actually passed a value in for that parameter.mailbox.Mailbox.pop: the_TTypeVar will go unsolved if the second overload is selected and no value is passed in for thedefaultvalue. The first overload covers the case where no value is specified for thedefaultparameter, so the= ...for the second overload is incorrect and unnecessary.