Skip to content

fix: l2_limit_for_tiling #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2025
Merged

fix: l2_limit_for_tiling #3479

merged 1 commit into from
Apr 27, 2025

Conversation

zewenli98
Copy link
Collaborator

Description

If the default -1 is passed in, it will output a warning.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Apr 17, 2025
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Apr 17, 2025
@github-actions github-actions bot requested a review from peri044 April 17, 2025 21:43
@zewenli98 zewenli98 force-pushed the fix_l2_limit_for_tiling branch from c9253c7 to cbd415b Compare April 17, 2025 21:46
@github-actions github-actions bot requested a review from peri044 April 24, 2025 23:39
@peri044 peri044 merged commit a1f37ad into main Apr 27, 2025
69 checks passed
peri044 pushed a commit that referenced this pull request Apr 27, 2025
@zewenli98 @peri044
fix: l2_limit_for_tiling (#3479)
d880297
peri044 added a commit that referenced this pull request Apr 27, 2025
@peri044 @zewenli98
fix: l2_limit_for_tiling (#3479) cherry pick to 2.7 (#3493)
b3ef68e 
Co-authored-by: Zewen (Evan) Li <zewenl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 Awaiting requested review from peri044

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths needs-release-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zewenli98 @peri044 @narendasan @facebook-github-bot