Skip to content

dev accounts #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2022
Merged

dev accounts #1372

merged 5 commits into from
Oct 26, 2022

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Oct 20, 2022

Referenced issues

Description of the Change

Support --alice, --bob, --charlie, --dave, --eve, --ferdie flags from substrate.

Benefits

Don't need keystore for testing.

Possible Drawbacks

Usage Examples or Tests

  • examples/first_kagome_chain with --alice.
  • examples/network with --alice and --bob.
  • examples/network_x4 with --alice, --bob, --charlie and --dave.

Alternate Designs

  • bip39 junctions are not supported yet

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1372 (caacb6c) into master (8781526) will increase coverage by 0.02%.
The diff coverage is 32.91%.

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
+ Coverage   24.18%   24.20%   +0.02%     
==========================================
  Files         627      628       +1     
  Lines       23447    23520      +73     
  Branches    12252    12287      +35     
==========================================
+ Hits         5670     5693      +23     
- Misses      12505    12537      +32     
- Partials     5272     5290      +18     
Impacted Files Coverage Δ
core/application/app_configuration.hpp 100.00% <ø> (ø)
core/application/impl/app_configuration_impl.hpp 26.92% <0.00%> (-1.46%) ⬇️
core/crypto/crypto_store/crypto_store_impl.cpp 24.48% <0.00%> (ø)
core/crypto/crypto_store/crypto_store_impl.hpp 36.17% <0.00%> (-1.61%) ⬇️
core/crypto/ed25519_types.hpp 0.00% <0.00%> (ø)
core/crypto/sr25519_types.hpp 20.00% <0.00%> (-5.00%) ⬇️
core/injector/get_peer_keypair.hpp 6.97% <0.00%> (ø)
core/injector/application_injector.cpp 32.79% <17.39%> (-0.38%) ⬇️
core/application/impl/app_configuration_impl.cpp 24.17% <42.30%> (+0.73%) ⬆️
core/crypto/crypto_store/dev_mnemonic_phrase.hpp 55.00% <55.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@turuslan turuslan requested review from xDimon and iceseer October 21, 2022 07:09
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from xDimon October 21, 2022 09:14
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from iceseer October 25, 2022 14:36
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan force-pushed the feature/dev-accounts branch from 9e07a86 to caacb6c Compare October 26, 2022 09:09
@turuslan turuslan merged commit 88bfa95 into master Oct 26, 2022
@turuslan turuslan deleted the feature/dev-accounts branch October 26, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants