Skip to content

[parachain] [fix] era points fixup #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jan 26, 2025
Merged

[parachain] [fix] era points fixup #2340

merged 33 commits into from
Jan 26, 2025

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Jan 15, 2025

Referenced issues

  1. Added additional logs for parachain tracing.
  2. ViewSize bounded MAX_VIEW_HEADS.
  3. backing_threshold usage depends on cluster/grid.
  4. Our assignment depends on claims queue.

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

iceseer and others added 25 commits January 15, 2025 14:58
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
1
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
This reverts commit 01d6866.
This reverts commit c771c63.
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer marked this pull request as ready for review January 23, 2025 06:54
@iceseer iceseer requested review from xDimon and kamilsa January 23, 2025 07:01
@iceseer iceseer changed the title print validator groups era points fixup Jan 23, 2025
@iceseer iceseer changed the title era points fixup [parachain] era points fixup Jan 23, 2025
@iceseer iceseer changed the title [parachain] era points fixup [parachain] [fix] era points fixup Jan 23, 2025
break;
}
}
std::ranges::sort(heads_);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to sort before take and emplace?

@iceseer iceseer enabled auto-merge (squash) January 26, 2025 17:32
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer merged commit 53b26a2 into master Jan 26, 2025
13 checks passed
@iceseer iceseer deleted the test/era_points_research branch January 26, 2025 18:09
@turuslan turuslan mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants