-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bitwise option to Sympy evaluator for classical controls #6914
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6914 +/- ##
=======================================
Coverage 97.86% 97.87%
=======================================
Files 1084 1084
Lines 94315 94406 +91
=======================================
+ Hits 92301 92396 +95
+ Misses 2014 2010 -4 ☔ View full report in Codecov by Sentry. |
@mhucka glitch :( |
@daxfohl I restarted the checks, but if it's okay with you, I'll leave it to you to update the branch again (otherwise, my name will be attached to this PR as a contributor, and that's not fair). |
@daxfohl thanks for the contribution ... does this fix also work with simulators? |
Yes, the test case shows it working with |
@ikd-sci can you check if this change does what you want? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @daxfohl , this looks great
Allow using sympy indexed objects to isolate bits within a measurement and perform bitwise logic on them.
Fixes #6434