Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the license statement for examples/ #7173

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Mar 21, 2025

The statement about everyone being free to copy, publish, etc., was ambiguous; after discussion with @Dstrain, we settled on adding mention of the Apache license.

While I was at it, I got rid of my previous hacky solution for formatting the note, in favor of using GFM's simple markup for info boxes.

The statement about everyone being free to copy, publish, etc., was
ambiguous; after discussion with @Dstrain, we settled on adding
mention of the Apache license.

While I was at it, I got rid of my previous hacky solution to
highlighting the note in favor of using GFM's markup.
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (4bdf21f) to head (7f8a782).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7173      +/-   ##
==========================================
- Coverage   98.13%   98.13%   -0.01%     
==========================================
  Files        1095     1095              
  Lines       95649    95649              
==========================================
- Hits        93867    93866       -1     
- Misses       1782     1783       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka mhucka marked this pull request as ready for review March 21, 2025 18:40
@mhucka mhucka requested review from vtomole and a team as code owners March 21, 2025 18:40
@mhucka mhucka requested review from dabacon and pavoljuhas March 21, 2025 18:40
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a fixed URL

@mhucka mhucka enabled auto-merge March 21, 2025 18:56
@mhucka mhucka added this pull request to the merge queue Mar 21, 2025
Merged via the queue into quantumlib:main with commit 71c3cf1 Mar 21, 2025
38 checks passed
@mhucka mhucka deleted the mh-update-examples-license branch March 21, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants