[Bug Fix]: qpc sdk config dump issue fixing #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
asmigosw
reviewed
Apr 24, 2025
quic-rishinr
requested changes
Apr 25, 2025
QEfficient/utils/_utils.py
Outdated
| @@ -492,7 +492,7 @@ def create_and_dump_qconfigs( | |||
| many other compilation options. | |||
| """ | |||
| qnn_config = compiler_options["qnn_config"] if "qnn_config" in compiler_options else None | |||
There was a problem hiding this comment.
you can replace it as compiler_options.get("qnn_config", None)
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
|
LGTM |
quic-rishinr
requested changes
May 6, 2025
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
QEfficient/utils/_utils.py
Outdated
| qnn_sdk_yaml_path = os.path.join(qnn_sdk_path, QnnConstants.QNN_SDK_YAML) | ||
| with open(qnn_sdk_yaml_path, "r") as file: | ||
| qnn_sdk_details = yaml.safe_load(file) | ||
| qnn_config_path = qnn_config if qnn_config is not None else QnnConstants.QNN_DEFAULT_CONFIG_PATH |
There was a problem hiding this comment.
If qnn_config is passed as None, we should be mentioning qnn_config_path as None only, since QNN_DEFAULT_CONFIG_PATH will not be used here. Also, in case where we are using qefficient as a package and dont have access to the qefficient repository, qnn_config will not be present in the default path.
@quic-rishinr Please validate the observation.
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
|
Thanks @abukhoy for incorporating the comment. LGTM |
quic-hemagnih
approved these changes
May 8, 2025
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
quic-rishinr
approved these changes
May 8, 2025
asmigosw
approved these changes
May 8, 2025
mohiso22
pushed a commit
to mohiso22/efficient_transformers
that referenced
this pull request
May 14, 2025
This PR addresses an issue causing the qconfig dump to fail when QAIC is not installed but QNN is present. With this update, the qconfig will be successfully dumped in both QAIC and QNN environments. --------- Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> Signed-off-by: Mohit Soni <quic_mohisoni@quicinc.com>
mohiso22
pushed a commit
to mohiso22/efficient_transformers
that referenced
this pull request
May 14, 2025
This PR addresses an issue causing the qconfig dump to fail when QAIC is not installed but QNN is present. With this update, the qconfig will be successfully dumped in both QAIC and QNN environments. --------- Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> Signed-off-by: Mohit Soni <quic_mohisoni@quicinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue causing the qconfig dump to fail when QAIC is not installed but QNN is present. With this update, the qconfig will be successfully dumped in both QAIC and QNN environments.