Hash bug fix pr #384
Merged
Hash bug fix pr #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please share both the model cards, with that you have faced this issue? @qcdipankar |
qcdipankar
force-pushed
the
hash_bug_fix_pr
branch
from
d5006f5 to
d8164e4
Compare
|
There is no need of creating another var as model_name, just use |
qcdipankar
force-pushed
the
hash_bug_fix_pr
branch
from
d8164e4 to
81fb24c
Compare
quic-amitraj
requested changes
May 13, 2025
|
Remove breakpoint and make the changes. CI is failing, kindly check. |
quic-hemagnih
approved these changes
May 14, 2025
|
Is the CI passing now with the code changes |
qcdipankar
force-pushed
the
hash_bug_fix_pr
branch
from
6263312 to
7437bc2
Compare
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
qcdipankar
force-pushed
the
hash_bug_fix_pr
branch
from
1698357 to
2b4daef
Compare
quic-rishinr
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding model_card_name to hash
Addition of model_card_name to hash helps to deal with error which occurs when two models sharing the same architecture but have different model card names and weights.
In future if any more parameters are required to make the hash unique, they can be a part of the kwargs as implemeted here.