Expose IP address for Acceptor #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceapasoi
changed the title
|
@cbusbey What do you think of this approach? |
cbusbey
requested changes
Feb 5, 2020
| @@ -100,6 +101,11 @@ func (a *Acceptor) Stop() { | |||
| a.sessionGroup.Wait() | |||
| } | |||
|
|
|||
| func (a *Acceptor) RemoteAddr(sessionID SessionID) (net.Addr, bool) { | |||
There was a problem hiding this comment.
Since you are adding to the package api, could you add a comment here describing the method for api users that will be picked up by godoc?
level2player
pushed a commit
to longbridge/quickfix
that referenced
this pull request
Jul 19, 2022
Expose IP address for Acceptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #388 I'd like to implement IP whitelisting functionality.
I've noticed that QuickFIX/J implements this functionality through the
AllowedRemoteAddressesconfig ("List of remote IP addresses which are allowed to connect to this acceptor"):https://www.quickfixj.org/usermanual/2.1.0/usage/configuration.html
While this is a good solution for static sessions, it doesn't work for my use-case because I'm using dynamic sessions.
The simplest solution I could think of was to add a
RemoteAddr(sessionID)method on the Acceptor that can be used to get the address for a particular session.