Skip to content

Support index deletes with an index pattern #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fmassot opened this issue Sep 15, 2023 · 4 comments · Fixed by #4606
Closed

Support index deletes with an index pattern #3841

fmassot opened this issue Sep 15, 2023 · 4 comments · Fixed by #4606
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fmassot
Copy link
Collaborator

fmassot commented Sep 15, 2023

elasticsearch muti target doc

elastic index delete API

This feature should be first implemented in the elasticsearch compatible API (under _elastic).

Additional notes:

  • The delete with index patterns containing wildcards should not be enabled by default. It is ok to give a list of index IDs.
  • We should return an elasticsearch-like response.
@fmassot fmassot added the enhancement New feature or request label Sep 15, 2023
@fmassot fmassot changed the title Support delete with an index patttern Support index delete with an index patttern Sep 15, 2023
@fmassot fmassot changed the title Support index delete with an index patttern Support index deletes with an index patttern Sep 15, 2023
@trinity-1686a trinity-1686a changed the title Support index deletes with an index patttern Support index deletes with an index pattern Sep 15, 2023
@fmassot fmassot added the good first issue Good for newcomers label Sep 26, 2023
@matthewfollegot
Copy link

👋 Hello @fmassot, I was looking into potentially picking this up, what's the status with this issue?

@fmassot
Copy link
Collaborator Author

fmassot commented Jan 28, 2024

@matthewfollegot cool! We have a small time constraint on it; if you can't work on it in the following days (some work was also done on it in a PR), we can find you another issue.

@matthewfollegot
Copy link

matthewfollegot commented Jan 29, 2024

I started on this and should be able to make more progress tomorrow.
Just a question for you in the meantime: would you prefer this to be a separate endpoint than the DELETE "/indexes/{index_id}" endpoint? I think it would be cleaner than separating it out into its own, but this would make this endpoint slower because we'd have to submit a search query for each pattern to get the index_id. An improvement would be to only search if it contains certain characters (e.g. *, .), but we'd still have to search over patterns that include these.

@esatterwhite
Copy link
Collaborator

esatterwhite commented Feb 5, 2024

I think this should support at least the ignore_unavailable query param.

if ignore_unavailable is set to true it shouldn't be considered a success if the index in question is missing rather than 404.

@PSeitz PSeitz assigned PSeitz and unassigned matthewfollegot Feb 19, 2024
PSeitz added a commit that referenced this issue Feb 19, 2024
PSeitz added a commit that referenced this issue Feb 20, 2024
PSeitz added a commit that referenced this issue Feb 21, 2024
PSeitz added a commit that referenced this issue Feb 27, 2024
PSeitz added a commit that referenced this issue Feb 27, 2024
* add support delete index in es API

closes #3841

* add test for delete on es API

* handle delete query param ignore_unavailable

* disallow delete indices, compat with es tests

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
5 participants