Skip to content

feat: Support TIME columns with subsecond precision #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

renkun-ken
Copy link
Contributor

@renkun-ken renkun-ken commented Oct 28, 2022

Closes #288

This PR fixes reading TIME column by preserving second_part which will otherwise be lost in a roundtrip.

  • Fix
  • Test case

@renkun-ken
Copy link
Contributor Author

@krlmlr This PR is ready for review. Please feel free to modify anything.

@krlmlr krlmlr changed the title Preserve second_part for TIME column feat: Support TIME columns with subsecond precision Oct 31, 2022
@krlmlr krlmlr merged commit c627a95 into r-dbi:main Oct 31, 2022
@krlmlr
Copy link
Member

krlmlr commented Oct 31, 2022

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precision lost for time(6) fields
2 participants