-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[setup-r]: R 4.5.0 (devel) needs newer gfortran #966
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2-branch #966 +/- ##
==========================================
Coverage 84.61% 84.61%
==========================================
Files 3 3
Lines 13 13
==========================================
Hits 11 11
Misses 2 2 ☔ View full report in Codecov by Sentry. |
CodeQL manual fix, need to replace
with
|
Needed to replace ``` let e=A.replace("*","(.*)"); ``` with ``` let e=A.replace(/[*]/g,"(.*)"); ```
b5bc710
to
b10b5c8
Compare
lgtm. Btw to build portable macos binary packages (that run on a system that does nos not have the gfortran toolchain installed) we need to override FLIBS to link to gfortran that is part of the R framework, like so: https://github.com/r-universe-org/actions/tree/v5/macos-prep/gfortran-14 But I don't think that matters for just checking the package locally. |
I don't really understand why the CRAN R build is not doing that by default... |
@gaborcsardi mind raising that to Simon on r-macos-sig? |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
Closes #965.