Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[setup-r]: R 4.5.0 (devel) needs newer gfortran #966

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Jan 31, 2025

Closes #965.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (8c5e6e8) to head (b10b5c8).
Report is 1 commits behind head on v2-branch.

Additional details and impacted files
@@            Coverage Diff             @@
##           v2-branch     #966   +/-   ##
==========================================
  Coverage      84.61%   84.61%           
==========================================
  Files              3        3           
  Lines             13       13           
==========================================
  Hits              11       11           
  Misses             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaborcsardi
Copy link
Member Author

CodeQL manual fix, need to replace

let e=A.replace("*","(.*)");

with

let e=A.replace(/[*]/g,"(.*)");

Needed to replace
```
let e=A.replace("*","(.*)");
```
with
```
let e=A.replace(/[*]/g,"(.*)");
```
@gaborcsardi gaborcsardi requested a review from jeroen January 31, 2025 09:57
@jeroen
Copy link
Member

jeroen commented Jan 31, 2025

lgtm. Btw to build portable macos binary packages (that run on a system that does nos not have the gfortran toolchain installed) we need to override FLIBS to link to gfortran that is part of the R framework, like so: https://github.com/r-universe-org/actions/tree/v5/macos-prep/gfortran-14

But I don't think that matters for just checking the package locally.

@gaborcsardi
Copy link
Member Author

Btw to build portable macos binary packages (that run on a system that does nos not have the gfortran toolchain installed) we need to override FLIBS to link to gfortran that is part of the R framework,

I don't really understand why the CRAN R build is not doing that by default...

@gaborcsardi gaborcsardi merged commit c4612eb into v2-branch Jan 31, 2025
34 checks passed
@gaborcsardi gaborcsardi deleted the fix/gfortran-r-4.5.0 branch January 31, 2025 12:27
@coatless
Copy link
Contributor

@gaborcsardi mind raising that to Simon on r-macos-sig?

Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github action fails on macOS r-devel, but not r-release, because of missing gfortran and emutls_w
3 participants