Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't trim 100-multiple VTE_VERSION #452

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Conversation

MichaelChirico
Copy link
Contributor

Closes #441 again

Tested with

VTE_VERSION='6800'
package_version(list(major = 0, minor = sprintf("%2.02f", as.numeric(VTE_VERSION) / 100)))
# [1] ‘0.68.0’

VTE_VERSION='5202'
package_version(list(major = 0, minor = sprintf("%2.02f", as.numeric(VTE_VERSION) / 100)))
# [1] ‘0.52.2’

@gaborcsardi
Copy link
Member

gaborcsardi commented Apr 25, 2022

Thanks! Should we put this whole VTE part into a bit tryCatch(), just in case? And maybe have a warning instead of an error?

@gaborcsardi gaborcsardi merged commit 23ab07e into r-lib:main Apr 26, 2022
@gaborcsardi
Copy link
Member

Thanks again!

@bbolker
Copy link
Contributor

bbolker commented Jul 4, 2022

A request to update the version of cli on CRAN soon, if possible (this was merged one day after the last CRAN release). This bit me again today (see r-lib/devtools#2439) and it would have taken me another hour or so to track down if I hadn't had a vague memory of where I saw it before ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: invalid version specification ‘6003’
3 participants