Fallback to a default code_highlight() theme if RStudio theme is unavailable
#482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heme_default_term()`
Plus add NEWS for r-lib#482.
|
Thanks! I added an option to suppress the warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
code_theme_default_rstudio()is unavailable,code_highlight()falls back tocode_theme_default_term():I opted to use the default terminal theme instead of an RStudio theme, because the existing RStudio themes were probably designed with a specific background color in mind.
I also preserved the existing warning message if the theme is unrecognized, but this could be removed if it is no longer considered necessary.
Closes #481.