Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unique() S3 methods (#277) #283

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

lewinfox
Copy link
Contributor

@lewinfox lewinfox commented Jun 8, 2021

Closes #277

  • Implement unique.units()
  • Implement unique.mixed_units()
  • Add tests

* Implement `unique.units()`
* Implement `unique.mixed_units()`
* Add tests
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #283 (00f23ac) into master (019b3f7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   94.41%   94.42%   +0.01%     
==========================================
  Files          18       18              
  Lines         877      879       +2     
==========================================
+ Hits          828      830       +2     
  Misses         49       49              
Impacted Files Coverage Δ
R/misc.R 100.00% <100.00%> (ø)
R/mixed.R 98.14% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019b3f7...00f23ac. Read the comment docs.

@Enchufa2
Copy link
Member

Enchufa2 commented Jun 8, 2021

LGTM, thanks!

@Enchufa2 Enchufa2 merged commit 271e32d into r-quantities:master Jun 8, 2021
@lewinfox lewinfox deleted the unique-units branch June 8, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unique() drops units
2 participants