Skip to content

Add contributing note #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2021
Merged

Add contributing note #60

merged 2 commits into from
Jun 27, 2021

Conversation

gmcgibbon
Copy link
Member

It isn't immediately clear to contributors that lookup tables in Marcel are generated (example). I've added a contributing note and comment at the top of the generated file that it shouldn't be edited.

@gmcgibbon gmcgibbon requested a review from pixeltrix June 25, 2021 23:48
@gmcgibbon gmcgibbon force-pushed the contributing_note branch from db182a5 to c018ec9 Compare June 25, 2021 23:50
Copy link
Contributor

@pixeltrix pixeltrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the typo - thanks 👍🏻

@gmcgibbon gmcgibbon force-pushed the contributing_note branch from c018ec9 to 01a8306 Compare June 27, 2021 19:17
@gmcgibbon gmcgibbon merged commit 51a8f55 into rails:main Jun 27, 2021
@gmcgibbon gmcgibbon deleted the contributing_note branch June 27, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants