Skip to content

#235 Display operation scopes if defined in security scheme #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

mb1511
Copy link
Contributor

@mb1511 mb1511 commented Feb 23, 2021

Slight UI change to display required scopes for OAuth 2.0 access tokens when defined in the operation security field (https://swagger.io/specification/#optional-oauth2-security) e.g.

  security: 
    - OAuth:
      - required/scope:read
      - required/scope:write

Example display:

rapidoc_oauth

Related to #235

Also added a link to the auth section, though ideally it would link to the exact auth flow.

Copy link
Collaborator

@mrin9 mrin9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
However styling needs to get approved from UX.
Instead of back n forth with the contributor, I suggest to merge as is to record the contribution and styling can be changed later (if needed) based on UX feedback

@mrin9 mrin9 merged commit 619eda7 into rapi-doc:master Feb 23, 2021
@mrin9
Copy link
Collaborator

mrin9 commented Feb 23, 2021

Thank you for the PR !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants