[core] Skip `setproctitle` tests on non-Linux machines #51229

kevin85421 · 2025-03-10T23:40:22Z

Why are these changes needed?

#51158 adds tests for process titles. However, the definition of "title" varies across different operating systems, and the behavior of psutil.Process().name() differs as well.

[ref]: https://github.com/dvarrazzo/py-setproctitle
> The process title is usually visible in files such as /proc/PID/cmdline,
/proc/PID/status, /proc/PID/comm, depending on the operating system and
kernel version. This information is used by user-space tools such as ps
and top.

For example, in Linux, the /proc/pid/comm can't be more than 15 chars. However, MacOS doesn't have /proc/pid/comm. In the following test, the name of the process in Mac is "python3.9", but the name on Linux is "ray::A.check".

    def test_main_thread_short_comm(self, ray_start_regular):
        """
        Test that the main thread's comm is not truncated.
        """
        @ray.remote
        class A:
            def check(self):
                pid = os.getpid()
                assert _is_actor_task_running(pid, "check")
                assert psutil.Process(pid).name() == "ray::A.check"
                assert psutil.Process(pid).cmdline()[0] == "ray::A.check"
                return pid
        a = A.remote()
        pid = ray.get(a.check.remote())
        wait_for_condition(lambda: not _is_actor_task_running(pid, "check"))

Related issue number

Closes #51182
Closes #45966

Checks

I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it in doc/source/tune/api/ under the
  corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

On my Mac M3

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>

kevin85421 · 2025-03-11T06:32:18Z

The failure seems to be unrelated

kevin85421 · 2025-03-11T06:34:18Z

This PR fixes the post-merge failures in #51182. However, the premerge fails consistently, and the failure seems to be unrelated #51229 (comment). Is it OK to merge to fix the post-merge failure?

…1229) ray-project#51158 adds tests for process titles. However, the definition of "title" varies across different operating systems, and the behavior of `psutil.Process().name()` differs as well. ``` [ref]: https://github.com/dvarrazzo/py-setproctitle > The process title is usually visible in files such as /proc/PID/cmdline, /proc/PID/status, /proc/PID/comm, depending on the operating system and kernel version. This information is used by user-space tools such as ps and top. ``` For example, in Linux, the `/proc/pid/comm` can't be more than 15 chars. However, MacOS doesn't have `/proc/pid/comm`. In the following test, the name of the process in Mac is "python3.9", but the name on Linux is "ray::A.check". ```python def test_main_thread_short_comm(self, ray_start_regular): """ Test that the main thread's comm is not truncated. """ @ray.remote class A: def check(self): pid = os.getpid() assert _is_actor_task_running(pid, "check") assert psutil.Process(pid).name() == "ray::A.check" assert psutil.Process(pid).cmdline()[0] == "ray::A.check" return pid a = A.remote() pid = ray.get(a.check.remote()) wait_for_condition(lambda: not _is_actor_task_running(pid, "check")) ``` ## Related issue number Closes ray-project#51182 Closes ray-project#45966 On my Mac M3 <img width="1728" alt="image" src="https://github.com/user-attachments/assets/c8c0addf-9c18-402d-bafd-135ff8f6ea7a" /> Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>

…1229) ray-project#51158 adds tests for process titles. However, the definition of "title" varies across different operating systems, and the behavior of `psutil.Process().name()` differs as well. ``` [ref]: https://github.com/dvarrazzo/py-setproctitle > The process title is usually visible in files such as /proc/PID/cmdline, /proc/PID/status, /proc/PID/comm, depending on the operating system and kernel version. This information is used by user-space tools such as ps and top. ``` For example, in Linux, the `/proc/pid/comm` can't be more than 15 chars. However, MacOS doesn't have `/proc/pid/comm`. In the following test, the name of the process in Mac is "python3.9", but the name on Linux is "ray::A.check". ```python def test_main_thread_short_comm(self, ray_start_regular): """ Test that the main thread's comm is not truncated. """ @ray.remote class A: def check(self): pid = os.getpid() assert _is_actor_task_running(pid, "check") assert psutil.Process(pid).name() == "ray::A.check" assert psutil.Process(pid).cmdline()[0] == "ray::A.check" return pid a = A.remote() pid = ray.get(a.check.remote()) wait_for_condition(lambda: not _is_actor_task_running(pid, "check")) ``` ## Related issue number Closes ray-project#51182 Closes ray-project#45966 On my Mac M3 <img width="1728" alt="image" src="https://github.com/user-attachments/assets/c8c0addf-9c18-402d-bafd-135ff8f6ea7a" /> Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: Jay Chia <17691182+jaychia@users.noreply.github.com>

…1229) ray-project#51158 adds tests for process titles. However, the definition of "title" varies across different operating systems, and the behavior of `psutil.Process().name()` differs as well. ``` [ref]: https://github.com/dvarrazzo/py-setproctitle > The process title is usually visible in files such as /proc/PID/cmdline, /proc/PID/status, /proc/PID/comm, depending on the operating system and kernel version. This information is used by user-space tools such as ps and top. ``` For example, in Linux, the `/proc/pid/comm` can't be more than 15 chars. However, MacOS doesn't have `/proc/pid/comm`. In the following test, the name of the process in Mac is "python3.9", but the name on Linux is "ray::A.check". ```python def test_main_thread_short_comm(self, ray_start_regular): """ Test that the main thread's comm is not truncated. """ @ray.remote class A: def check(self): pid = os.getpid() assert _is_actor_task_running(pid, "check") assert psutil.Process(pid).name() == "ray::A.check" assert psutil.Process(pid).cmdline()[0] == "ray::A.check" return pid a = A.remote() pid = ray.get(a.check.remote()) wait_for_condition(lambda: not _is_actor_task_running(pid, "check")) ``` ## Related issue number Closes ray-project#51182 Closes ray-project#45966 On my Mac M3 <img width="1728" alt="image" src="https://github.com/user-attachments/assets/c8c0addf-9c18-402d-bafd-135ff8f6ea7a" /> Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>

…1229) ray-project#51158 adds tests for process titles. However, the definition of "title" varies across different operating systems, and the behavior of `psutil.Process().name()` differs as well. ``` [ref]: https://github.com/dvarrazzo/py-setproctitle > The process title is usually visible in files such as /proc/PID/cmdline, /proc/PID/status, /proc/PID/comm, depending on the operating system and kernel version. This information is used by user-space tools such as ps and top. ``` For example, in Linux, the `/proc/pid/comm` can't be more than 15 chars. However, MacOS doesn't have `/proc/pid/comm`. In the following test, the name of the process in Mac is "python3.9", but the name on Linux is "ray::A.check". ```python def test_main_thread_short_comm(self, ray_start_regular): """ Test that the main thread's comm is not truncated. """ @ray.remote class A: def check(self): pid = os.getpid() assert _is_actor_task_running(pid, "check") assert psutil.Process(pid).name() == "ray::A.check" assert psutil.Process(pid).cmdline()[0] == "ray::A.check" return pid a = A.remote() pid = ray.get(a.check.remote()) wait_for_condition(lambda: not _is_actor_task_running(pid, "check")) ``` ## Related issue number Closes ray-project#51182 Closes ray-project#45966 On my Mac M3 <img width="1728" alt="image" src="https://github.com/user-attachments/assets/c8c0addf-9c18-402d-bafd-135ff8f6ea7a" /> Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>

update

6536341

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>

kevin85421 marked this pull request as ready for review March 10, 2025 23:49

kevin85421 assigned dayshah Mar 10, 2025

dayshah approved these changes Mar 10, 2025

View reviewed changes

dayshah added the go add ONLY when ready to merge, run all tests label Mar 10, 2025

Merge branch 'master' into laptop-repro-proc-title

843669a

kevin85421 assigned edoakes and jjyao Mar 11, 2025

edoakes merged commit 53ce608 into ray-project:master Mar 11, 2025
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Skip `setproctitle` tests on non-Linux machines #51229

[core] Skip `setproctitle` tests on non-Linux machines #51229

kevin85421 commented Mar 10, 2025 •

edited

Loading

kevin85421 commented Mar 11, 2025

kevin85421 commented Mar 11, 2025

[core] Skip setproctitle tests on non-Linux machines #51229

[core] Skip setproctitle tests on non-Linux machines #51229

Conversation

kevin85421 commented Mar 10, 2025 • edited Loading

Why are these changes needed?

Related issue number

Checks

kevin85421 commented Mar 11, 2025

kevin85421 commented Mar 11, 2025

[core] Skip `setproctitle` tests on non-Linux machines #51229

[core] Skip `setproctitle` tests on non-Linux machines #51229

kevin85421 commented Mar 10, 2025 •

edited

Loading