[core] Record dashboard metrics with oneshot #51627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dayshah <dhyey2019@gmail.com>
|
Very nice! Did you sanity check the flamegraph after the change? |
sanity checked now, 2.8% -> 1.6%. |
angelinalg
pushed a commit
to angelinalg/ray
that referenced
this pull request
Mar 26, 2025
While looking at a dashboard flame graph, memory_full_info was actually visible even though it only runs every 5 seconds. Our two calls mean we're getting the info twice so even more expensive, and it can also result in inconsistent info between uss and rss. We also get an additional speedup by using with oneshot() with getting cpu percent as well. https://psutil.readthedocs.io/en/latest/#psutil.Process.oneshot. --------- Signed-off-by: dayshah <dhyey2019@gmail.com>
dhakshin32
pushed a commit
to dhakshin32/ray
that referenced
this pull request
Mar 27, 2025
While looking at a dashboard flame graph, memory_full_info was actually visible even though it only runs every 5 seconds. Our two calls mean we're getting the info twice so even more expensive, and it can also result in inconsistent info between uss and rss. We also get an additional speedup by using with oneshot() with getting cpu percent as well. https://psutil.readthedocs.io/en/latest/#psutil.Process.oneshot. --------- Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
d-miketa
pushed a commit
to d-miketa/ray
that referenced
this pull request
Mar 28, 2025
While looking at a dashboard flame graph, memory_full_info was actually visible even though it only runs every 5 seconds. Our two calls mean we're getting the info twice so even more expensive, and it can also result in inconsistent info between uss and rss. We also get an additional speedup by using with oneshot() with getting cpu percent as well. https://psutil.readthedocs.io/en/latest/#psutil.Process.oneshot. --------- Signed-off-by: dayshah <dhyey2019@gmail.com>
srinathk10
pushed a commit
that referenced
this pull request
Mar 28, 2025
While looking at a dashboard flame graph, memory_full_info was actually visible even though it only runs every 5 seconds. Our two calls mean we're getting the info twice so even more expensive, and it can also result in inconsistent info between uss and rss. We also get an additional speedup by using with oneshot() with getting cpu percent as well. https://psutil.readthedocs.io/en/latest/#psutil.Process.oneshot. --------- Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
While looking at a dashboard flame graph, memory_full_info was actually visible even though it only runs every 5 seconds. Our two calls mean we're getting the info twice so even more expensive, and it can also result in inconsistent info between uss and rss. We also get an additional speedup by using with oneshot() with getting cpu percent as well. https://psutil.readthedocs.io/en/latest/#psutil.Process.oneshot.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.