[serve] Remove RAY_SERVE_ENABLE_QUEUE_LENGTH_CACHE flag #51649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T_MAX_ONGOING_REQUESTS ff Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
edoakes
approved these changes
Mar 24, 2025
akyang-anyscale
changed the title
omatthew98
approved these changes
Mar 24, 2025
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Mar 25, 2025
…51649) ## Why are these changes needed? This PR removes a feature flag that controls whether the proxy should use cached replica queue length values for routing. The FF was [introduced](ray-project#42943) over a year ago as a way for users to quickly switch back to the previous implementation. It has been enabled by default for [over a year](ray-project#43169) now and works as expected, so let's remove it. Consequently, this PR also removes `RAY_SERVE_ENABLE_STRICT_MAX_ONGOING_REQUESTS`, as it is always enabled if `RAY_SERVE_ENABLE_QUEUE_LENGTH_CACHE` is enabled. Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
dhakshin32
pushed a commit
to dhakshin32/ray
that referenced
this pull request
Mar 27, 2025
…51649) ## Why are these changes needed? This PR removes a feature flag that controls whether the proxy should use cached replica queue length values for routing. The FF was [introduced](ray-project#42943) over a year ago as a way for users to quickly switch back to the previous implementation. It has been enabled by default for [over a year](ray-project#43169) now and works as expected, so let's remove it. Consequently, this PR also removes `RAY_SERVE_ENABLE_STRICT_MAX_ONGOING_REQUESTS`, as it is always enabled if `RAY_SERVE_ENABLE_QUEUE_LENGTH_CACHE` is enabled. Signed-off-by: akyang-anyscale <alexyang@anyscale.com> Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
d-miketa
pushed a commit
to d-miketa/ray
that referenced
this pull request
Mar 28, 2025
…51649) ## Why are these changes needed? This PR removes a feature flag that controls whether the proxy should use cached replica queue length values for routing. The FF was [introduced](ray-project#42943) over a year ago as a way for users to quickly switch back to the previous implementation. It has been enabled by default for [over a year](ray-project#43169) now and works as expected, so let's remove it. Consequently, this PR also removes `RAY_SERVE_ENABLE_STRICT_MAX_ONGOING_REQUESTS`, as it is always enabled if `RAY_SERVE_ENABLE_QUEUE_LENGTH_CACHE` is enabled. Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
srinathk10
pushed a commit
that referenced
this pull request
Mar 28, 2025
## Why are these changes needed? This PR removes a feature flag that controls whether the proxy should use cached replica queue length values for routing. The FF was [introduced](#42943) over a year ago as a way for users to quickly switch back to the previous implementation. It has been enabled by default for [over a year](#43169) now and works as expected, so let's remove it. Consequently, this PR also removes `RAY_SERVE_ENABLE_STRICT_MAX_ONGOING_REQUESTS`, as it is always enabled if `RAY_SERVE_ENABLE_QUEUE_LENGTH_CACHE` is enabled. Signed-off-by: akyang-anyscale <alexyang@anyscale.com> Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes a feature flag that controls whether the proxy should use cached replica queue length values for routing. The FF was introduced over a year ago as a way for users to quickly switch back to the previous implementation. It has been enabled by default for over a year now and works as expected, so let's remove it. Consequently, this PR also removes
RAY_SERVE_ENABLE_STRICT_MAX_ONGOING_REQUESTS, as it is always enabled ifRAY_SERVE_ENABLE_QUEUE_LENGTH_CACHEis enabled.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.