[core] Fix all variable shadowing for core worker #51672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <dentinyhao@gmail.com>
dentiny
force-pushed
the
hjiang/fix-all-variable-shadowing-core-worker
branch
from
e311047 to
f05b681
Compare
dayshah
approved these changes
Mar 25, 2025
I have another pr to turn on the option, but failed to pass ci |
dentiny
changed the title
edoakes
approved these changes
Mar 25, 2025
angelinalg
pushed a commit
to angelinalg/ray
that referenced
this pull request
Mar 25, 2025
This PR fixes all variable shadowing for core worker. Variable shadowing is known to be error prune --- I personally just spent 20 minute debugging an issue caused by it. Need to address all issues before ray-project#51669 Signed-off-by: dentiny <dentinyhao@gmail.com>
dentiny
added a commit
to dentiny/ray
that referenced
this pull request
Mar 25, 2025
This PR fixes all variable shadowing for core worker. Variable shadowing is known to be error prune --- I personally just spent 20 minute debugging an issue caused by it. Need to address all issues before ray-project#51669 Signed-off-by: dentiny <dentinyhao@gmail.com>
This was referenced Mar 26, 2025
dhakshin32
pushed a commit
to dhakshin32/ray
that referenced
this pull request
Mar 27, 2025
This PR fixes all variable shadowing for core worker. Variable shadowing is known to be error prune --- I personally just spent 20 minute debugging an issue caused by it. Need to address all issues before ray-project#51669 Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
d-miketa
pushed a commit
to d-miketa/ray
that referenced
this pull request
Mar 28, 2025
This PR fixes all variable shadowing for core worker. Variable shadowing is known to be error prune --- I personally just spent 20 minute debugging an issue caused by it. Need to address all issues before ray-project#51669 Signed-off-by: dentiny <dentinyhao@gmail.com>
srinathk10
pushed a commit
that referenced
this pull request
Mar 28, 2025
This PR fixes all variable shadowing for core worker. Variable shadowing is known to be error prune --- I personally just spent 20 minute debugging an issue caused by it. Need to address all issues before #51669 Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all variable shadowing for core worker.
Variable shadowing is known to be error prune --- I personally just spent 20 minute debugging an issue caused by it.
Need to address all issues before #51669