Skip to content

Fixed broken link in docs #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Conversation

timmattison
Copy link
Contributor

Fixed a broken link to the class that shows the three byte integer parsing example.

BTW, is there an easier way to do this? I have several values that are 22, 23, or 24 bit integers that are not neatly aligned to byte boundaries. I want to be able to read them with minimal configuration and custom code. I think I understand how to do this with values that are less than 8 bits but not with more than 8 bits.

@raydac
Copy link
Owner

raydac commented Aug 6, 2018

you can just make custom type processor like int24 int22 int23, take a look at example

@timmattison
Copy link
Contributor Author

I was looking for a more generic solution so that I don't have to create a new class for each different integer size. I want to be able to use the DSL builder and if I use custom types I think I lose that as well.

@raydac
Copy link
Owner

raydac commented Aug 6, 2018

it is interesting idea to add way to mark and custom field types through annotation as minimum for DSL builder, I will think how to implement

@raydac
Copy link
Owner

raydac commented Aug 8, 2018

I have added DslBinCustom annotation which provides way to mark custom typed fields for JBBPDslBuilder

@raydac raydac merged commit f382110 into raydac:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants