Highlighting the current frame does not work

[przepompownia]

Currently I can't see which frame is current.

I found DapUICurrentFrameName highlight inside frames.lua but it doesn't seem to be applied. :Inspect on the current frame's line shows

[przepompownia]

nvim-dap-ui/lua/dapui/components/frames.lua

Line 34 in 34160a7

local is_current = frame.id == current_frame_id

I noticed that for PHP adapter for none of frames frame.id == current_frame_id.

Please look into the example from https://github.com/przepompownia/nvim-dap-ui-current-frame-bug (make start should be enough).

I'm not sure if the bug lies on nvim-dap-ui side.

[przepompownia]

I see that .frames from nvim-dap displays the current frame correctly

but after jumping to another frame using default o keymap on the stacks window the current frame is not displayed also there

Moreover, jumping between frames by require('dap').up() also returns then an error:

[przepompownia]

I noticed that using frames directly from dap.session

diff --git a/lua/dapui/components/frames.lua b/lua/dapui/components/frames.lua
index 7d1c87c..afbd653 100644
--- a/lua/dapui/components/frames.lua
+++ b/lua/dapui/components/frames.lua
@@ -19,6 +19,7 @@ return function(client, send_ready)
         return
       end
       local frames = response.stackFrames
+      frames = require'dap'.session().threads[thread_id].frames
 
       if not show_subtle then
         frames = vim.tbl_filter(function(frame)

simply works in this example

and does not break .frames output and jumping between frames.

[rcarriga]

Thanks for the fix, I added a few extra changes and pushed to master

[przepompownia]

Thank you too. I took a look at how you made the access to frames without direct requireing dap.session in lua/dapui/components/frames.lua. It works for me so we can close this issue.

[przepompownia]

...althoug I get

   Warn  06:24:06 PM notify.warn nvim-dap-ui Rendering failed: ...k/bundle/opt/nvim-dap-ui/lua/dapui/components/frames.lua:21: attempt to index a nil value
stack traceback:
	...nfig/nvim/pack/bundle/opt/nvim-dap-ui/lua/dapui/util.lua:26: in function '__index'
	...k/bundle/opt/nvim-dap-ui/lua/dapui/components/frames.lua:21: in function 'render'
	.../bundle/opt/nvim-dap-ui/lua/dapui/components/threads.lua:45: in function 'render_thread'
	.../bundle/opt/nvim-dap-ui/lua/dapui/components/threads.lua:73: in function 'render'
	...ack/bundle/opt/nvim-dap-ui/lua/dapui/elements/stacks.lua:27: in function 'render'
	...ack/bundle/opt/nvim-dap-ui/lua/dapui/elements/stacks.lua:19: in function <...ack/bundle/opt/nvim-dap-ui/lua/dapui/elements/stacks.lua:18>
	[C]: in function 'xpcall'
	...nfig/nvim/pack/bundle/opt/nvim-dap-ui/lua/dapui/util.lua:25: in function <...nfig/nvim/pack/bundle/opt/nvim-dap-ui/lua/dapui/util.lua:21>

after exiting if continue does not meet any breakpoint.

[mikehaertl]

Commit a62e86b related to this issue introduced a new error for me. See #321

[przepompownia]

Currently in my local env I have

diff --git a/lua/dapui/components/frames.lua b/lua/dapui/components/frames.lua
index f15323b..bc42310 100644
--- a/lua/dapui/components/frames.lua
+++ b/lua/dapui/components/frames.lua
@@ -18,6 +18,18 @@ return function(client, send_ready)

       local current_frame_id = nil

+      local threads = client.session.threads
+
+      if not threads then
+        vim.notify('No threads for session', vim.log.levels.ERROR, {title = 'DAP UI'})
+        return
+      end
+
+      if not threads[thread_id] then
+        vim.notify('No thread ' .. thread_id, vim.log.levels.ERROR, {title = 'DAP UI'})
+        return
+      end
+
       local frames = client.session.threads[thread_id].frames
       if not frames then
         return

to debug what part of path is nil (and avoid this error in a regular work).

[mikehaertl]

No thread 1
No thread 7

[przepompownia]

@mikehaertl thanks for pointing out the place. Do you have a working frames view after this change?

[mikehaertl]

TBH I'm not sure what frames are. I see threads, though. Here's what a session looks like (Java):

[przepompownia]

@mikehaertl you have visible frames on the screenshot. The widget hierarchy is DAP Stacks -> threads -> frames (@rcarriga please correct me if I'm wrong).