Skip to content

Unexpected file auto-reformatting when 'Automatically decode entities' is checked #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xomx opened this issue Dec 20, 2024 · 8 comments
Labels
bug Something isn't working
Milestone

Comments

@xomx
Copy link

xomx commented Dec 20, 2024

I was bitten by the following, when updating my translation file.
IDK if it is a feature or bug and can be prevented somehow(?).

STR (using fresh x64 N++ portable v8.7.4):

  • HTMLTag installed via PluginAdmin (v1.5.1)
  • in N++ open .\localization\english.xml
  • go to item id 6910 there ( Ctrl+F for <Item id="6910" name="Minimum Size for Auto-Checking &quot;In selection":"/> )
  • move cursor at the EOL:
    HTMLTag-plugin-before
  • press Enter:
    HTMLTag-plugin-after
@rdipardo rdipardo added the bug Something isn't working label Dec 20, 2024
@rdipardo rdipardo added this to the v1.5.2 milestone Dec 20, 2024
@rdipardo
Copy link
Owner

rdipardo commented Dec 20, 2024

I can't tell from the image but I'm supposing the EOL mode is CRLF, right?

The SCN_CHARADDED hook has puzzled me for a long time; TAB does not appear to trigger it, yet it fires twice for DOS EOLs: once for \r, and again for \n 🤔

Never mind; the real issue was a too-greedy backtracking loop: 6e3800c

@rdipardo
Copy link
Owner

Should be fixed now: https://app.circleci.com/pipelines/github/rdipardo/nppHTMLTag/18/workflows/05a1cc7f-a1a8-4f9d-b3a3-cf7ca31db307/jobs/19/artifacts

Note: build artifacts expire in 30 days

@xomx
Copy link
Author

xomx commented Dec 21, 2024

Tested - ok.
Thanks for the quick fix and this useful plugin!

@xomx xomx closed this as completed Dec 21, 2024
@xomx xomx reopened this Dec 21, 2024
@xomx
Copy link
Author

xomx commented Dec 21, 2024

Eee, no, I spoke too soon. In the

Should be fixed now: https://app.circleci.com/pipelines/github/rdipardo/nppHTMLTag/18/workflows/05a1cc7f-a1a8-4f9d-b3a3-cf7ca31db307/jobs/19/artifacts

is no new HTMLTag.dll binary file, only ini!
So I actually tested that english.xml file without any HTMLTag plugin behind...

Edit: Only arm64 zip contains the binary.

@rdipardo
Copy link
Owner

@xomx

Only arm64 zip contains the binary.

Yep. The x86 Intel builds were targeting XP. It seems at some time in the past two weeks the XP v141 toolset was pulled by Microsoft (with no announcement 🤔?) and then Circle CI upgraded their image to pull in the newest VS Studio release.

No plans on reverting to Free Pascal for the sake of XP, though. Plugin versions 1.4.4 and older will even run on NT 4.0, yes, but Pascal's memory model is broke-ass and the code looks like a dog's breakfast.

No harm done since my earlier "fix" actually had a major regression in it.

Newest builds are here: https://app.circleci.com/pipelines/github/rdipardo/nppHTMLTag/19/workflows/42899453-91c3-4c69-8496-c2287fb12936/jobs/20/artifacts

@xomx
Copy link
Author

xomx commented Dec 21, 2024

@rdipardo
Works ok, thanks again.

@xomx xomx closed this as completed Dec 21, 2024
@rdipardo
Copy link
Owner

Issues without a patched version on the Plugin List can stay open in case other users come here to report the same thing.

@rdipardo rdipardo reopened this Dec 22, 2024
@rdipardo
Copy link
Owner

Fixed in HTML Tag 1.5.2, available via Plugins Admin, if you are using Notepad++ 8.7.6 or newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants