Skip to content

chore(testapp): bump RNTA to latest 3.x #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Feb 20, 2024

Overview

Hey team 👋

A few weeks back I noticed this PR #583 and it made me realise that we (RNTA authors) haven't created proper docs for how to upgrade both the RN version and the RNTA version of an existing RNTA-based test app 😱 sorry about that! (I'll get to that soon!)

So I took a bit of time today to bump this repo's example app to latest RNTA.
It's actually pretty simple:

  • you change the version in the package.json of the example app (you don't need the one in the root level, so I removed it - yes, it's another thing that we can tweak in the docs to make clearer)
  • you run yarn configure-test-app --force; it will basically update and realign the files so that it will be as-if you just generated the example app with latest RNTA
  • you verify the changes and remove anything extra that shouldn't be there

And this PR is the result of that; as you can see with RNTA 2.0 -> 3.0 some files got nicely cleaned up, like the metro config and the react-native config (less things to keep track of!)

Merging this PR should also mean that #477 can be closed (cc @Naturalclar)

Test Plan

The commands for testing the test app work just fine; so

yarn bootstrap
yarn example start
yarn example android
yarn example ios

all work.

Here's a (not that meaningful since well the whole point was that nothing should change) screenshot comparison:

Before (RNTA 2)

RNTA 2

After (RNTA 3)

RNTA 3

bump RNTA to 3.0

(forgot to update the lock of the example)

update project to 3

cleanup

tweak
@kelset kelset requested a review from Naturalclar as a code owner February 20, 2024 18:29
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much! ill try to apply these changes to other repositories as well

@Naturalclar Naturalclar merged commit 4fa42b8 into react-native-menu:master Feb 21, 2024
@kelset kelset deleted the kelset/update-rnta-to-3 branch February 21, 2024 11:24
@kelset
Copy link
Contributor Author

kelset commented Feb 21, 2024

(side update: we added a dedicated page in the wiki https://github.com/microsoft/react-native-test-app/wiki/Upgrading )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants