chore(testapp): bump RNTA to latest 3.x #712
Merged
+315
−453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hey team 👋
A few weeks back I noticed this PR #583 and it made me realise that we (RNTA authors) haven't created proper docs for how to upgrade both the RN version and the RNTA version of an existing RNTA-based test app 😱 sorry about that! (I'll get to that soon!)
So I took a bit of time today to bump this repo's example app to latest RNTA.
It's actually pretty simple:
yarn configure-test-app --force
; it will basically update and realign the files so that it will be as-if you just generated the example app with latest RNTAAnd this PR is the result of that; as you can see with RNTA 2.0 -> 3.0 some files got nicely cleaned up, like the metro config and the react-native config (less things to keep track of!)
Merging this PR should also mean that #477 can be closed (cc @Naturalclar)
Test Plan
The commands for testing the test app work just fine; so
all work.
Here's a (not that meaningful since well the whole point was that nothing should change) screenshot comparison:
Before (RNTA 2)
After (RNTA 3)