Skip to content

Add ordered unreliables #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 13, 2025
Merged

Conversation

daimond113
Copy link
Contributor

Adds ordered unreliables, which work by serializing an order id (u16) that gets reset whenever it overflows the maximum size. Packets received with older and/or equal order ids, and without a significant drop (a reset from the maximum value to 0) are not handled.

Fixes #61.

Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general piece of feedback in this PR is to not do these hacky save and load calls.

@sasial-dev sasial-dev self-assigned this Apr 12, 2025
dai and others added 4 commits April 12, 2025 08:31
Co-authored-by: Sasial <44125644+sasial-dev@users.noreply.github.com>
Co-authored-by: Sasial <44125644+sasial-dev@users.noreply.github.com>
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sasial-dev sasial-dev merged commit e158af8 into red-blox:0.6.x Apr 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add "OrderedUnreliable" Type
2 participants