Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autodiscoverFilter)!: support combined negative matches #34707

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 9, 2025

Changes

Migrates autodiscoverFilter to use Renovate's common matchRegexOrGlob capability, therefore allowing one or more negative filters to be used compatibly with positive filters.

Context

Closes #21347

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added the breaking Breaking change, requires major version bump label Mar 9, 2025
@rarkins rarkins requested review from viceice and secustor March 9, 2025 06:34
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 9, 2025

Probably should be rebased against Next?

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to be rebased onto next.

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but should target v40

@viceice viceice added this to the v40 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add autodiscoverExclusions to exclude projects fetched by autodiscoverFilter
3 participants