Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix coverage for platform code #34719

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Mar 9, 2025

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov changed the title test: Fix coverage for GitHub platform test: Fix coverage for platform code Mar 9, 2025
@zharinov zharinov requested review from rarkins and viceice March 9, 2025 23:27
@@ -95,12 +95,13 @@ export async function getFile(
return null;
}
}
} catch {
} catch /* v8 ignore start */ {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a logger.trace() be reached here, or this catch is never tested?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It never was actually covered

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far. did you checked if all are needed? I found that some code was already covered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants