-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix coverage for platform code #34719
base: main
Are you sure you want to change the base?
Conversation
@@ -95,12 +95,13 @@ export async function getFile( | |||
return null; | |||
} | |||
} | |||
} catch { | |||
} catch /* v8 ignore start */ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a logger.trace() be reached here, or this catch is never tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It never was actually covered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far. did you checked if all are needed? I found that some code was already covered
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: