refactor(gradle): make uri parsing reusable

[patrick-dedication]

Changes

Moves gradle uri parsing to common to make it reusable.

Context

I've got a first walking skeleton for #14208.
I would like to make some preparatory refactorings to make the feature PR concise.

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[patrick-dedication]

Not sure if varTokens is a good "interface".
Should I do storeInTokenMap(ctx, 'url') or storeInTokenMap(ctx, 'uri')?

[Churro]

There are already plenty of tests for the different URL patterns that should cover all currently supported combinations. I don't think we need to add them redundantly:

renovate/lib/modules/manager/gradle/parser.spec.ts

Lines 659 to 703 in 0ad6d0a

	describe('custom registries', () => {
	it.each`
	def | input | url
	${''} | ${'maven("")'} | ${null}
	${''} | ${'maven(["https://foo.bar/baz/qux"])'} | ${null}
	${''} | ${'maven("foo", "bar")'} | ${null}
	${''} | ${'maven("https://foo.bar/baz")'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven("${base}/baz")'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven(base)'} | ${'https://foo.bar'}
	${''} | ${'maven(url = "https://foo.bar/baz")'} | ${'https://foo.bar/baz'}
	${''} | ${'maven(url = uri("https://foo.bar/baz"))'} | ${'https://foo.bar/baz'}
	${''} | ${'maven(uri("https://foo.bar/baz"))'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven(uri("${base}/baz"))'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven(uri(property("base")))'} | ${'https://foo.bar'}
	${'base="https://foo.bar"'} | ${'maven(uri(base))'} | ${'https://foo.bar'}
	${'base="https://foo.bar"'} | ${'maven(uri(base + "/baz"))'} | ${'https://foo.bar/baz'}
	${''} | ${'maven(uri(["https://foo.bar/baz"]))'} | ${null}
	${''} | ${'maven { ["https://foo.bar/baz"] }'} | ${null}
	${''} | ${'maven { url "https://foo.bar/baz" }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { url base + "/baz" }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { url "${base}/baz" }'} | ${'https://foo.bar/baz'}
	${''} | ${'maven { url uri("https://foo.bar/baz") }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { url uri("${base}/baz") }'} | ${'https://foo.bar/baz'}
	${''} | ${'maven { url = "https://foo.bar/baz" }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { url = "${base}/baz" }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { url = property("base") }'} | ${'https://foo.bar'}
	${'base="https://foo.bar"'} | ${'maven { url = base }'} | ${'https://foo.bar'}
	${''} | ${'maven { url = uri("https://foo.bar/baz") }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { url = uri("${base}/baz") }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { url = uri(base) }'} | ${'https://foo.bar'}
	${''} | ${'maven { uri(["https://foo.bar/baz"]) }'} | ${null}
	${'base="https://foo.bar"'} | ${'maven { name "baz"\nurl = "${base}/${name}" }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { name "${base}" + "/baz"\nurl = "${name}" + "/qux" }'} | ${'https://foo.bar/baz/qux'}
	${'base="https://foo.bar"'} | ${'maven { name = "baz"\nurl = "${base}/${name}" }'} | ${'https://foo.bar/baz'}
	${'some="baz"'} | ${'maven { name = "${some}"\nurl = "https://foo.bar/${name}" }'} | ${'https://foo.bar/baz'}
	${'some="foo.bar/baz"'} | ${'maven { name = property("some")\nurl = "https://${name}" }'} | ${'https://foo.bar/baz'}
	${'some="baz"'} | ${'maven { name = some\nurl = "https://foo.bar/${name}" }'} | ${'https://foo.bar/baz'}
	${''} | ${'maven { setUrl("https://foo.bar/baz") }'} | ${'https://foo.bar/baz'}
	${''} | ${'maven { setUrl(uri("https://foo.bar/baz")) }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { setUrl("${base}/baz") }'} | ${'https://foo.bar/baz'}
	${'base="https://foo.bar"'} | ${'maven { setUrl(project.property("base")) }'} | ${'https://foo.bar'}
	${'base="https://foo.bar"'} | ${'maven { setUrl(base) }'} | ${'https://foo.bar'}
	${''} | ${'maven { setUrl(["https://foo.bar/baz"]) }'} | ${null}
	${''} | ${'maven { setUrl("foo", "bar") }'} | ${null}
	${'base="https://foo.bar"'} | ${'publishing { repositories { maven("${base}/baz") } }'} | ${null}

[patrick-dedication]

For someone new to the codebase like me having these tests helps a lot, because:

• I can check if my change works on a smaller scale
• I can pinpoint problems, I had a really hard time finding out where in the whole parser setup things weren't working out for me

[Churro]

Could you please open a working / draft PR with your implementation of exclusiveContent first?

This would allow a better review of needed refactoring changes. They could then still be split into a separate PR.

[patrick-dedication]

Could you please open a working / draft PR with your implementation of exclusiveContent first?

This would allow a better review of needed refactoring changes. They could then still be split into a separate PR.

Sure, will do, but that will take a few more days :)
I had the impression this change makes sense anyways?

[Churro]

Could you please open a working / draft PR with your implementation of exclusiveContent first?
This would allow a better review of needed refactoring changes. They could then still be split into a separate PR.

Sure, will do, but that will take a few more days :) I had the impression this change makes sense anyways?

Without further context, I don't see the value of moving qUri to common.ts, as it is only needed for registry URL parsing and therefore locally scoped. Context-wise a parser definition for exclusiveContent would also fit best into registry-urls.ts

[patrick-dedication]

@Churro finally got around to polishing up at least a little.
I will incorporate the changes you made in common.ts when we have discussed the implementation.
Find the draft here #34771, I didn't know how to mark it as draft properly.
More than happy to discuss the implementation :)