Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gitlab): implement pr cache #34747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

Cache pull requests using repository cache

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Sorry, something went wrong.

@rarkins rarkins requested a review from zharinov March 11, 2025 16:24

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
const url = `/projects/${this.repo}/merge_requests?${query}`;

const res = await http.getJsonUnchecked<GitLabMergeRequest[]>(url, {
paginate: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, this is very expensive. please check other pr cache implementations for less expensive ways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants