Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed File browser for browsing assets/ #155

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

MickHarrigan
Copy link
Contributor

Addresses #148.

Currently relies on the git repo for egui_file until there is a new release that will have the required change on crates.io.

@naomijub
Copy link
Collaborator

naomijub commented Jan 3, 2024

Currently relies on the git repo for egui_file until there is a new release that will have the required change on crates.io.

Personally I would wait them release to merge the PR. @rewin123 ?

@rewin123
Copy link
Owner

rewin123 commented Jan 3, 2024

I think we can merge the PR and, lest we forget, immediately create an Issue to update the egui_file version when it comes out, which is likely to happen before 0.4 is released, since egui_file has up to two releases a month, and space_editor is still scheduled for release at the end of February.

@rewin123 rewin123 added the bug Something isn't working label Jan 3, 2024
@rewin123 rewin123 added this to the 0.4 milestone Jan 3, 2024
@naomijub naomijub mentioned this pull request Jan 3, 2024
Copy link
Collaborator

@naomijub naomijub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on @rewin123 comment #157

@rewin123 rewin123 merged commit a404944 into rewin123:main Jan 3, 2024
@naomijub
Copy link
Collaborator

naomijub commented Jan 3, 2024

Thanks a lot @MickHarrigan

@MickHarrigan MickHarrigan deleted the fixed branch January 6, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants