Harpoon port #6
Draft
Harpoon port #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
|
this looks awesome! |
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
MinhPhan8803
force-pushed
the
harpoon_port
branch
from
e648081 to
182bf51
Compare
jinghao-jia
reviewed
Mar 23, 2025
| // Design decision: the equivalent BPF helper writes the program name to | ||
| // a user-provided buffer, here we can take advantage of Rust's ownership by | ||
| // just providing a reference to the CString instead | ||
| pub fn get_comm(&self) -> Result<&CStr, ffi::FromBytesUntilNulError> { |
There was a problem hiding this comment.
Since this changes the function signature, the samples that use this function will need to be updated as well
jinghao-jia
reviewed
Mar 23, 2025
rex-macros/src/kprobe.rs
Outdated
| let fn_name = self.item.sig.ident.clone(); | ||
| let item = &self.item; | ||
| let function_name = format!("{}", fn_name); | ||
| let prog_ident = | ||
| format_ident!("PROG_{}", fn_name.to_string().to_uppercase()); | ||
|
|
||
| let attached_function = if self.function.is_some() { | ||
| format!("rex/kprobe/{}", self.function.as_ref().unwrap()) | ||
| format!("rex/{}/{}", flavor, self.function.as_ref().unwrap()) | ||
| } else { | ||
| "rex/kprobe".to_string() |
There was a problem hiding this comment.
This does not respect the kprobe flavor
There was a problem hiding this comment.
Probably we could put the flavor inside the KProbe struct
jinghao-jia
reviewed
Mar 23, 2025
| @@ -0,0 +1,31 @@ | |||
| [package] | |||
| name = "hello" | |||
There was a problem hiding this comment.
Just remember to change the sample name/metadata in all places.
jinghao-jia
reviewed
Mar 23, 2025
jinghao-jia
reviewed
Mar 23, 2025
jinghao-jia
reviewed
Mar 23, 2025
chinrw
reviewed
Mar 23, 2025
rex-macros/src/kprobe.rs
Outdated
| let fn_name = self.item.sig.ident.clone(); | ||
| let item = &self.item; | ||
| let function_name = format!("{}", fn_name); | ||
| let prog_ident = | ||
| format_ident!("PROG_{}", fn_name.to_string().to_uppercase()); | ||
|
|
||
| let attached_function = if self.function.is_some() { | ||
| format!("rex/kprobe/{}", self.function.as_ref().unwrap()) | ||
| format!("rex/{}/{}", flavor, self.function.as_ref().unwrap()) | ||
| } else { | ||
| "rex/kprobe".to_string() |
There was a problem hiding this comment.
Probably we could put the flavor inside the KProbe struct
| process.kill() | ||
| std_out, std_err = process.communicate(timeout=7) | ||
| re_match = re.findall( | ||
| r"bpf_trace_printk: Rust triggered from PID \d+ on CPU .+", std_out, re.M |
There was a problem hiding this comment.
will we have sanity test case for harpoon?
There was a problem hiding this comment.
Yes, but I haven't started working on the backend for the userspace app yet so I haven't really thought about what tests will look like.
…method to grab pointer from tp_ctx, fix KproveFlavor use, fix TaskStruct::get_comm use Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
MinhPhan8803
force-pushed
the
harpoon_port
branch
from
81d75ef to
30f8795
Compare
… app Signed-off-by: MinhPhan8803 <nhatminhvinh8803@gmail.com>
MinhPhan8803
force-pushed
the
harpoon_port
branch
from
b451d02 to
6d23109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently WIP, not available to merge yet.
Add definition for
PerfEventArrayand its helper symbols. For thebpf_perf_event_outputsymbol specifically, currently only thebpf_perf_event_output_tpvariant is supported.Add the
StreamableProgramtrait that program types that can stream events throughPerfEventArrayshould implement. This allows unifying the various streaming symbols into a singleStreamableProgram::output_event()method in a manner similar to the overloaded helperbpf_perf_event_output().Add a
rex_uprobemacro and aKprobeFlavorenum inrex-macros/src/kprobe.rsto allow switching between kprobe variants inKProbe::expand().Misc changes:
TaskStruct::get_comm()now returns a direct reference to the program name as a&CStr.BPF_F_CURRENT_CPUconstant asCURRENT_CPU.