fix unintended error when MC analysis reaches end #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
refer to #46 for some further context. |
robbievanleeuwen
approved these changes
Oct 10, 2022
|
@Agent6-6-6 thanks for this logic fix! |
Agent6-6-6
deleted the
fix-indended-failure-providing-warning-in-MC-analyses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robbievanleeuwen, this pull request addresses the
brentq algorithm fails.message occurring when the intended behaviour at the end of a moment curvature analysis is that thebrentqfails intentionally due to the concrete or steel strains being exceeded and the_failureflag being set byservice_normal_force_convergence()method.Will now only raise the warning if the
service_normal_force_convergence()method has not set the_failureflag to True.