feat: support using unicode as import/export name

[hyf0]

Description

[hyf0]

• feat: support using unicode as import/export name #1196 👈
• fix: rewrite dynamic import to correct entry chunk #1195
• feat: support bundling .json files #1194
• feat(rust): introduce Loader concept #1193
• chore(oxlint): enable jsdoc plugin #1192
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite

[github-actions]

Benchmarks Rust

• target: 05-22-fix_rewrite_dynamic_import_to_correct_entry_chunk(6b891cd)
• pr: 05-22-fix_support_using_unicode_as_import_export_name(a8d8f65)

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     29.6±0.38ms        ? ?/sec    1.00     29.6±0.35ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     20.9±0.22ms        ? ?/sec    1.00     21.0±0.39ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     41.8±1.38ms        ? ?/sec    1.00     41.9±1.57ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    322.8±5.65ms        ? ?/sec    1.00    322.1±4.78ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    207.6±2.16ms        ? ?/sec    1.00    208.3±4.30ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.02   465.5±10.00ms        ? ?/sec    1.00   455.0±11.85ms        ? ?/sec

Benchmarks Rust

• target: 05-22-fix_rewrite_dynamic_import_to_correct_entry_chunk(6b891cd)
• pr: 05-22-fix_support_using_unicode_as_import_export_name(a98c8ad)

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     29.5±0.19ms        ? ?/sec    1.00     29.6±0.60ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     20.9±0.45ms        ? ?/sec    1.00     21.0±0.54ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.01     41.4±1.29ms        ? ?/sec    1.00     41.1±1.02ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    321.4±2.40ms        ? ?/sec    1.00    320.4±1.95ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    212.4±3.76ms        ? ?/sec    1.00    211.4±3.20ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    451.4±9.12ms        ? ?/sec    1.00   452.3±10.58ms        ? ?/sec

Benchmarks Rust

• target: main(d242f3e)
• pr: 05-22-fix_support_using_unicode_as_import_export_name(6951234)

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     31.5±0.44ms        ? ?/sec    1.01     31.9±0.36ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     21.7±0.35ms        ? ?/sec    1.01     22.0±0.14ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     43.5±1.04ms        ? ?/sec    1.00     43.5±1.13ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    326.8±4.60ms        ? ?/sec    1.00    327.9±5.32ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    211.7±2.61ms        ? ?/sec    1.00    212.7±2.47ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.01    463.5±8.60ms        ? ?/sec    1.00   459.0±10.54ms        ? ?/sec

[codspeed-hq]

CodSpeed Performance Report

Merging #1196 will not alter performance

_{Comparing 05-22-fix_support_using_unicode_as_import_export_name (6951234) with main (d242f3e)}

Summary

✅ 6 untouched benchmarks

[Boshen]

https://docs.rs/oxc_syntax/0.13.0/oxc_syntax/identifier/fn.is_identifier_name.html

There's also non-unicode versions https://docs.rs/oxc_syntax/0.13.0/oxc_syntax/identifier/index.html#functions

oops, this comment should be in the previous PR 😅

[hyf0]

Oxc's one is much better/performant than regex. Let's replace it.

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.00%. Comparing base (6b891cd) to head (a98c8ad).

Files	Patch %	Lines
...s/rolldown/src/utils/chunk/render_chunk_exports.rs	85.71%	1 Missing ⚠️

Additional details and impacted files

@@                                     Coverage Diff                                     @@
##           05-22-fix_rewrite_dynamic_import_to_correct_entry_chunk    #1196      +/-   ##
===========================================================================================
+ Coverage                                                    86.98%   87.00%   +0.01%     
===========================================================================================
  Files                                                          128      128              
  Lines                                                         6264     6272       +8     
===========================================================================================
+ Hits                                                          5449     5457       +8     
  Misses                                                         815      815              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hyf0]

Merge activity

• May 21, 1:04 PM EDT: @hyf0 started a stack merge that includes this pull request via Graphite.
• May 21, 1:11 PM EDT: Graphite rebased this pull request as part of a merge.
• May 21, 1:12 PM EDT: @hyf0 merged this pull request with Graphite.

[netlify]

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	6951234
🔍 Latest deploy log	https://app.netlify.com/sites/rolldown-rs/deploys/664cd599b70b1500086fc26b