Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Update typescript version, add __generator helper #75

Closed
wants to merge 1 commit into from

Conversation

dmitry-korolev
Copy link

@dmitry-korolev dmitry-korolev commented Dec 14, 2016

Sup @Victorystick
I know that this is almost a duplicate of previous two PRs, except this one should pass travis build.
Main thing about this PR - it doesn't break anything. It just allows to use newest TS features - async/await and generators.

See, just requiring latest typescript doesn't help - it works, and it transpiles, but __generator helper is not imported, and an error occures: Push.ts:20 Uncaught (in promise) ReferenceError: __generator is not defined(…)

Copy link
Contributor

@eventualbuddha eventualbuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I'll merge if there are no objections, @Victorystick.

@notoriousb1t
Copy link

@Victorystick @eventualbuddha

Can this be merged? I believe that once it is merged, it will make it possible to update to head and merge #71 as well

@dmitry-korolev
Copy link
Author

@Victorystick
I literally have to bump, sorry.
I would appriciate any comment from you.

@carmanchris31
Copy link

Wanted to convert my promise callback workflow to await and ran into this problem too. Are there any objections to merging?

@belohlavek
Copy link

Other PRs depend on this. Please merge.

@kazzkiq
Copy link

kazzkiq commented Apr 25, 2017

@eventualbuddha Its been a while since this PR, and today TypeScript released yet another version. It would be extremely interesting to catch up with their updates as this plugin still uses an old version.

Do you guys have any news or plans to merge this PR?

@mohd-akram
Copy link

Would be great if this was merged.

@dmitry-korolev
Copy link
Author

I suggest using an alternative package: https://github.com/alexlur/rollup-plugin-typescript
Btw, thanks @alexlur!

@PaulBGD
Copy link
Collaborator

PaulBGD commented May 23, 2017

For anyone following this, #91 is where it's being worked on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants