Skip to content
This repository was archived by the owner on May 30, 2022. It is now read-only.

Response to rOpenSci reviewers #39

Merged
merged 27 commits into from
Apr 11, 2019
Merged

Response to rOpenSci reviewers #39

merged 27 commits into from
Apr 11, 2019

Conversation

Rekyt
Copy link
Collaborator

@Rekyt Rekyt commented Mar 30, 2019

The reviewers assigned by rOpenSci have sent great reviews 🎉
(reviewer 1: ropensci/software-review#285 (comment)
reviewer 2: ropensci/software-review#285 (comment))

The aim of this PR is to answer to reviewers by making the requested changes.

@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #39 into master will decrease coverage by 0.1%.
The diff coverage is 95.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   96.41%   96.31%   -0.11%     
==========================================
  Files           4        4              
  Lines         223      244      +21     
==========================================
+ Hits          215      235      +20     
- Misses          8        9       +1
Impacted Files Coverage Δ
R/rromeo_journals.R 100% <100%> (ø) ⬆️
R/rromeo_base.R 80% <50%> (-20%) ⬇️
R/rromeo_publishers.R 87.5% <87.87%> (-0.22%) ⬇️
R/utils.R 99.33% <98.78%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34c09e...fc9ee2e. Read the comment docs.

@Rekyt Rekyt mentioned this pull request Apr 1, 2019
@Rekyt Rekyt requested a review from Bisaloo April 8, 2019 14:34
@Rekyt Rekyt merged commit 82bb9e3 into master Apr 11, 2019
@Rekyt Rekyt deleted the ropensci-review1 branch April 18, 2019 05:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants