Fix one more HA scene problem #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postlund
reviewed
Dec 17, 2020
custom_components/localtuya/light.py
Outdated
| @@ -188,7 +188,9 @@ def hs_color(self): | |||
| """Return the hs color value.""" | |||
| if self.is_color_mode: | |||
| return self._hs | |||
| if self.supported_features & SUPPORT_COLOR: | |||
| if self.supported_features & SUPPORT_COLOR and not self.has_config( | |||
There was a problem hiding this comment.
I think you can do this:
if self.supported_features & (SUPPORT_COLOR | SUPPORT_COLOR_TEMP):There was a problem hiding this comment.
It's a not, I mean, in case SUPPORT_COLOR but does not SUPPORT_COLOR_TEMP => for RGB +W lights, not RGB + CCT
There was a problem hiding this comment.
Ah, right, missed that. But you should be able to use not. self.supported_features & SUPPORT_COLOR_TEMP for consistency.
postlund
approved these changes
Dec 17, 2020
SKULSHADY
pushed a commit
to SKULSHADY/localtuya
that referenced
this pull request
Dec 28, 2024
SKULSHADY
pushed a commit
to SKULSHADY/localtuya
that referenced
this pull request
Dec 28, 2024
…#275 * Fix socket.send() raised exception. * Fix the update_interval create multi tasks. * Adjust the logs to for sub-device and low-power devices. * Add msg for disconnected function. * Workaround to fix heartbeat not being. send because update_interval less then 5 secs. * Handle the fail connection expectations. * Add device ID and Name in logger when add new device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create a bunch of scenes with different kind of device configuration:
Found a case that needs this fix 😄