-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIrst try to add issue template #264
Conversation
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
name: Bug report | ||
about: Create a report to help us improve localtuya | ||
title: '' | ||
labels: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that you add bug here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about it, but as for the moment, we do not have a feature_request template, or a new_device template, should we do it know or automatically categorize once we have different templates ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Maybe we should just grab the bull by the horns and fix all of them? I have a few in my pyatv repo that has worked pretty well (for inspiration):
https://github.com/postlund/pyatv/tree/master/.github/ISSUE_TEMPLATE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a go at a PR template in #782
@rospogrigio I suggest that you make me and/or @ultratoto14 admins so we can steer the ship until you have time. That way you can just forget about localtuya until a better point in time. |
Yeah, totally agree: as I said from the very beginning it was just a matter of time until you'd better take over. Edit: wait... how am I supposed to do that?? |
@rospogrigio maybe in Settings -> Manage Access |
My bad, I was under the impression that the access levels were more fine grained that they are. Only the repository owner has super user power and there can only be one owner. Collaborators can't get the kind of permissions needed I'm afraid. |
@rospogrigio if you want @postlund to take the lead on this repository, it seems the only way is to transfer the ownership Seems that fine grained rights tuning is only for github enterprise. |
OK then, just one question: what will happen with the HACS integration? It is enlisted as rospogrigio/localtuya there, as far as I remember... |
@rospogrigio i created an empty repository and transfer you the ownership, will see, maybe you need to accept. |
@ultratoto14 Can't see it... |
@rospogrigio the repository https://github.com/ultratoto14/TestingRepository |
Yes, so it renamed the repository ... f.ck |
So, I suggest we investigate if there will be any issue with HACS, or if renaming the ownership can be transferred easily... |
By the way, it seems that the PR is working, tested it on my own repo. |
I guess we can transfer ownership and you immediately make a new fork of it @rospogrigio. That way HACS can point to the fork until we have updated the repo in HACS. |
It tells me that "postlund already has a repository in the mileperhour/localtuya-homeassistant network". |
If the repository is changed then all the users will also have to update their links. |
I have removed my local fork now, so hopefully it should work. Tried to read up a bit and I think all previous references will still work. So if anyone tries to use the old addresses, they will automatically point towards my repo, which means we are fine. People should still update to the new address though, we included when it comes to HACS. |
@postlund repository transfer requested :wink ... oops I transferred it to the trout!!! 🤣 |
@rospogrigio I am suppose to confirm, but maybe we should take another route instead. There's an organization for custom components here: https://github.com/custom-components I'm sort of taking ownership of the |
Let's merge this and see what happens... |
As I do not have the rights to use the repository workflow, trying in that way.