Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIrst try to add issue template #264

Merged
merged 3 commits into from
Apr 1, 2021
Merged

FIrst try to add issue template #264

merged 3 commits into from
Apr 1, 2021

Conversation

ultratoto14
Copy link
Collaborator

As I do not have the rights to use the repository workflow, trying in that way.

name: Bug report
about: Create a report to help us improve localtuya
title: ''
labels: ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that you add bug here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about it, but as for the moment, we do not have a feature_request template, or a new_device template, should we do it know or automatically categorize once we have different templates ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Maybe we should just grab the bull by the horns and fix all of them? I have a few in my pyatv repo that has worked pretty well (for inspiration):

https://github.com/postlund/pyatv/tree/master/.github/ISSUE_TEMPLATE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a go at a PR template in #782

@postlund
Copy link
Collaborator

@rospogrigio I suggest that you make me and/or @ultratoto14 admins so we can steer the ship until you have time. That way you can just forget about localtuya until a better point in time.

@ultratoto14 ultratoto14 requested a review from postlund December 21, 2020 09:54
@rospogrigio
Copy link
Owner

rospogrigio commented Dec 21, 2020

@rospogrigio I suggest that you make me and/or @ultratoto14 admins so we can steer the ship until you have time. That way you can just forget about localtuya until a better point in time.

Yeah, totally agree: as I said from the very beginning it was just a matter of time until you'd better take over.
Doing it now, I am quite overwhelmed these days...

Edit: wait... how am I supposed to do that??

@ultratoto14
Copy link
Collaborator Author

@rospogrigio maybe in Settings -> Manage Access
image

@rospogrigio
Copy link
Owner

You are already listes as Collaborators, and there is no "Admin" options:
image

@postlund
Copy link
Collaborator

My bad, I was under the impression that the access levels were more fine grained that they are. Only the repository owner has super user power and there can only be one owner. Collaborators can't get the kind of permissions needed I'm afraid.

@ultratoto14
Copy link
Collaborator Author

@rospogrigio if you want @postlund to take the lead on this repository, it seems the only way is to transfer the ownership

Seems that fine grained rights tuning is only for github enterprise.

@rospogrigio
Copy link
Owner

OK then, just one question: what will happen with the HACS integration? It is enlisted as rospogrigio/localtuya there, as far as I remember...

@ultratoto14
Copy link
Collaborator Author

@rospogrigio i created an empty repository and transfer you the ownership, will see, maybe you need to accept.

@rospogrigio
Copy link
Owner

rospogrigio commented Dec 21, 2020

@ultratoto14 Can't see it...
Edit: saw it, and accepted.

@ultratoto14
Copy link
Collaborator Author

@rospogrigio the repository https://github.com/ultratoto14/TestingRepository
In the settings, i currently have
image

@ultratoto14
Copy link
Collaborator Author

Yes, so it renamed the repository ... f.ck

@rospogrigio
Copy link
Owner

So, I suggest we investigate if there will be any issue with HACS, or if renaming the ownership can be transferred easily...

@ultratoto14
Copy link
Collaborator Author

By the way, it seems that the PR is working, tested it on my own repo.

@postlund
Copy link
Collaborator

I guess we can transfer ownership and you immediately make a new fork of it @rospogrigio. That way HACS can point to the fork until we have updated the repo in HACS.

@rospogrigio
Copy link
Owner

It tells me that "postlund already has a repository in the mileperhour/localtuya-homeassistant network".

@ultratoto14
Copy link
Collaborator Author

If the repository is changed then all the users will also have to update their links.

@postlund
Copy link
Collaborator

I have removed my local fork now, so hopefully it should work. Tried to read up a bit and I think all previous references will still work. So if anyone tries to use the old addresses, they will automatically point towards my repo, which means we are fine. People should still update to the new address though, we included when it comes to HACS.

@rospogrigio
Copy link
Owner

rospogrigio commented Dec 22, 2020

@postlund repository transfer requested :wink ... oops I transferred it to the trout!!! 🤣
Edit: do you confirm that I am supposed to make a new fork of the repo once you've accepted?

@postlund
Copy link
Collaborator

@rospogrigio I am suppose to confirm, but maybe we should take another route instead. There's an organization for custom components here:

https://github.com/custom-components

I'm sort of taking ownership of the remote_homeassistant component as well and we will move it to that organization. Maybe that's a better way to deal with this as well?

@postlund
Copy link
Collaborator

postlund commented Apr 1, 2021

Let's merge this and see what happens...

@postlund postlund merged commit 934a0f4 into master Apr 1, 2021
@postlund postlund deleted the issue_template branch April 1, 2021 16:43
SKULSHADY pushed a commit to SKULSHADY/localtuya that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants