Small memory optimizations #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of 3 changes
using file local quaternions for blending animation data to relieve gc pressure, it created 90KiB+ garbage per frame in the default example
changing node:set_rotation to to use rotation:set q instead of rotation = q to make it work like the set_position and set_scale siblings
storing skinning imagebuffers on the model and using ImageData directly instead of converting it from byte data
this solves hitches and recreating large amounts of data, which improved framerates a lot on my system,
i fear that the non-ffi path might penalize web with the 4 function calls but this version is also compatible with 11, might be an ok tradeoff