Fix warnings and a typo #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsl
force-pushed
the
fix_warnings_and_spelling
branch
from
ea78423 to
06fdfce
Compare
rswgnu
approved these changes
May 31, 2025
matsl
force-pushed
the
fix_warnings_and_spelling
branch
from
06fdfce to
b85cb7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix some warnings and a typo.
Why
Always try to keep warnings to a minimum.
Note
These warnings still remains:
In hsys-consult-selected-candidate:
hsys-consult.el:220:26: Warning: Unused lexical argument ‘lambda’
hsys-consult.el:220:34: Warning: Unused lexical variable ‘state-function’
hsys-consult.el:220:34: Warning: Unused lexical variable ‘`’
hsys-consult.el:220:34: Warning: Unused lexical variable ‘,’
hsys-consult.el:221:30: Warning: Unused lexical variable ‘state-function’
hsys-consult.el:221:48: Warning: Unused lexical variable ‘cand’
Looks strange to get these warnings but it is beyond me to figure out
what the problem is. At least without a lot more investigation. Can
there be a problem here?
In end of data:
hsys-www.el:144:48: Warning: the function ‘url-encode-string’ is not known to be defined.
I can't find where url-encode-string is defined? All our supported
versions of emacs warn for this. Can it be base64url-encode-string
that is meant to be used?