Skip to content

dtoa.c: Use an on-stack buffer for small bigints #13234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

dtoa.c: Use an on-stack buffer for small bigints #13234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
afa1eff
Eagerly initialize dtoa instead of using atomics
jhawthorn Apr 12, 2025
0371827
Extract MAXWDS
jhawthorn Apr 12, 2025
0ead738
More sensible Bcopy
jhawthorn Apr 12, 2025
123a89d
Remove maxwds
jhawthorn Apr 18, 2025
0b71a7e
Shrink fields of Bigint
jhawthorn Apr 18, 2025
ad889ce
Pass DTOA state through everything
jhawthorn Apr 18, 2025
aacb3d2
Pack struct better
jhawthorn Apr 18, 2025
ed38b29
On stack buffer for bigint allocations
jhawthorn Apr 18, 2025
41eebea
Cleanup hack
jhawthorn Apr 18, 2025
e02cfa0
Use int for wds again
jhawthorn Apr 18, 2025
a0af6c2
Update deps
jhawthorn May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6821,6 +6821,7 @@ eval.$(OBJEXT): $(top_srcdir)/internal/hash.h
eval.$(OBJEXT): $(top_srcdir)/internal/imemo.h
eval.$(OBJEXT): $(top_srcdir)/internal/inits.h
eval.$(OBJEXT): $(top_srcdir)/internal/io.h
eval.$(OBJEXT): $(top_srcdir)/internal/missing.h
eval.$(OBJEXT): $(top_srcdir)/internal/object.h
eval.$(OBJEXT): $(top_srcdir)/internal/sanitizers.h
eval.$(OBJEXT): $(top_srcdir)/internal/serial.h
Expand Down Expand Up @@ -18677,6 +18678,7 @@ transcode.$(OBJEXT): {$(VPATH)}transcode.c
transcode.$(OBJEXT): {$(VPATH)}transcode_data.h
util.$(OBJEXT): $(hdrdir)/ruby/ruby.h
util.$(OBJEXT): $(top_srcdir)/internal/array.h
util.$(OBJEXT): $(top_srcdir)/internal/bits.h
util.$(OBJEXT): $(top_srcdir)/internal/compilers.h
util.$(OBJEXT): $(top_srcdir)/internal/imemo.h
util.$(OBJEXT): $(top_srcdir)/internal/sanitizers.h
Expand Down
2 changes: 2 additions & 0 deletions eval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include "internal/object.h"
#include "internal/thread.h"
#include "internal/variable.h"
#include "internal/missing.h"
#include "ruby/fiber/scheduler.h"
#include "iseq.h"
#include "probes.h"
Expand Down Expand Up @@ -77,6 +78,7 @@ ruby_setup(void)
prctl(PR_SET_THP_DISABLE, 1, 0, 0, 0);
#endif
Init_BareVM();
ruby_init_dtoa();
rb_vm_encoded_insn_data_table_init();
Init_vm_objects();
Init_fstring_table();
Expand Down
3 changes: 3 additions & 0 deletions internal/missing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,7 @@ extern void ruby_init_setproctitle(int argc, char *argv[]);
extern void ruby_free_proctitle(void);
#endif

/* missing/dtoa.c */
void ruby_init_dtoa(void);

#endif /* INTERNAL_MISSING_H */
Loading
Loading