Update for Actions Windows MSYS2 install #39
Conversation
| // add MSYS2 paths for misc gnu utilities like bison and ragel | ||
| pathAry.push(`${msys2}\\mingw64\\bin`) | ||
| pathAry.push(`${msys2}\\usr\\bin`) | ||
| return pathAry |
There was a problem hiding this comment.
Could you use an array literal with ... to splat addVCVARSEnv()?
That would be closer to the code above in setupMingw and avoid mutating the array in place.
There was a problem hiding this comment.
I noticed that push allows multiple arguments, so I changed to that? VCVARSEnv is defined by the bat file, so we have to 'add' two arrays, but this is just adding two items...
| @@ -8,6 +8,12 @@ const exec = require('@actions/exec') | |||
| const tc = require('@actions/tool-cache') | |||
| const rubyInstallerVersions = require('./windows-versions').versions | |||
|
|
|||
| // needed for 2.2, 2.3, and mswin, cert file used by Git for Windows | |||
| const certFile = 'C:\\Program Files\\Git\\mingw64\\ssl\\cert.pem' | |||
There was a problem hiding this comment.
I hope this location will remain available, it sounds likely enough for now.
There was a problem hiding this comment.
Git for Windows has always been there. It's the git that's used by all the actions and any Windows devs using git. There are also GitHub/MSFT staff involved with it. IOW, its location is probably more locked down than the locations of the toolcache Rubies...
1. Use 'Git for Windows' cert.pem file 2. Add MSYS2 to path for mswin (after msvc additions) 3. Rearrange code for cleanup when MSYS2 is added to Window image
MSP-Greg
force-pushed
the
windows-cert-pem
branch
from
d2a032e to
6da6fff
Compare
The comment below precedes code that can be removed when MSYS2 is added.