improved digital compatibility docs #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankurte
requested review from
ilya-epifanov,
thejpster and
a team
as code owners
dbrgn
reviewed
May 19, 2019
| //! pub fn new(pin: T) -> OldOutputPinConsumer<T> { | ||
| //! OldOutputPinConsumer{ _pin: pin } | ||
| //! } | ||
| //! } |
There was a problem hiding this comment.
The docs could be a bit shorter if you'd skip the new function and simply make the _pin field pub pin instead, and then directly assign the value in main.
There was a problem hiding this comment.
i think i prefer the new method as it shows how you'd usually use it (with the where clause), am okay to change it if you disagree strongly.
| //! pub fn new(pin: T) -> NewOutputPinConsumer<T> { | ||
| //! NewOutputPinConsumer{ _pin: pin } | ||
| //! } | ||
| //! } |
There was a problem hiding this comment.
Same thing here with the new function.
|
bors r+ |
Build failed |
|
Again, bors build fails because we deny warnings. I'll create a PR to remove that line. |
|
bors retry |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.