Skip to content

async: add i2c #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2022
Merged

async: add i2c #348

merged 1 commit into from
Jan 18, 2022

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Jan 12, 2022

This mirrors the blocking i2c trait (including the changes proposed in #339 ), except the following:

  • Removed all iter methods since they don't play well with DMA.

@Dirbaio Dirbaio requested a review from a team as a code owner January 12, 2022 12:01
@rust-highfive
Copy link

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

@Dirbaio Dirbaio mentioned this pull request Jan 12, 2022
Closed
3 tasks
eldruin
eldruin approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straight-forward to me, thanks!
We could add an I2cIter trait in the future if there is a good use case.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 12, 2022

👎 Rejected by too few approved reviews

@eldruin
Copy link
Member

eldruin commented Jan 12, 2022

What? I just approved this

eldruin
eldruin approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 18, 2022

Build succeeded:

@bors bors bot merged commit 61285e4 into rust-embedded:master Jan 18, 2022
@eldruin eldruin mentioned this pull request Feb 10, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees

@ryankurte ryankurte

Labels
no changelog S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dirbaio @rust-highfive @eldruin @ryankurte