Skip to content

bus/spi: add RefCell, CriticalSection and Mutex shared bus implementations. #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Mar 14, 2023

Requires #443

This adds a few bus sharing implementations, with varying tradeoffs:

  • RefCellDevice: single thread only
  • CriticalSectionDevice: thread-safe, coarse locking, nostd.
  • MutexDevice: thread-safe, fine-grained locking, std only.

@Dirbaio Dirbaio requested a review from a team as a code owner March 14, 2023 21:44
@Dirbaio Dirbaio force-pushed the spi-bus-sharing branch 3 times, most recently from 9f5ebe1 to 762b421 Compare March 14, 2023 21:59
@eldruin eldruin added this to the v1.0.0 milestone Mar 15, 2023
@Dirbaio Dirbaio force-pushed the spi-bus-sharing branch 4 times, most recently from baa9cab to 4a15a6f Compare March 16, 2023 15:31
@Dirbaio Dirbaio force-pushed the spi-bus-sharing branch 2 times, most recently from 0f632e4 to e05979f Compare March 28, 2023 12:43
@eldruin
Copy link
Member

eldruin commented Apr 1, 2023

I hit the button too quickly in #443. Could you add entries to the changelog for the changes in #443 here or add a new PR?

@Dirbaio
Copy link
Member Author

Dirbaio commented Apr 1, 2023

@eldruin done

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
bors r+

@bors bors bot merged commit 0c98b79 into rust-embedded:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants