use logbot to log our IRC channel #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
added
the
needs-decision
adamgreig
approved these changes
Aug 22, 2018
hannobraun
approved these changes
Aug 22, 2018
andre-richter
approved these changes
Aug 22, 2018
sekineh
approved these changes
Aug 22, 2018
jamesmunns
approved these changes
Aug 22, 2018
thejpster
approved these changes
Aug 22, 2018
v-thakkar
approved these changes
Aug 22, 2018
danc86
approved these changes
Aug 22, 2018
ryankurte
approved these changes
Aug 23, 2018
korken89
approved these changes
Aug 23, 2018
|
10 people have approved this so this proposal has been approved. Logging is effective as of now: https://mozilla.logbot.info/rust-embedded bors r+ |
|
👎 Rejected by label |
japaric
removed
the
needs-decision
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 23, 2018
190: use logbot to log our IRC channel r=japaric a=japaric This a proposal to log our IRC channel using logbot. This proposal (PR) needs at least 10 votes (approvals) from @rust-embedded/all to be accepted. After the proposal has been accepted we'll proceed to implement it. @rust-embedded/all please vote on this proposal using [pull request reviews]. Or if you have a concern leave a comment. [pull request reviews]: https://help.github.com/articles/about-pull-request-reviews/ closes #171 Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a proposal to log our IRC channel using logbot.
This proposal (PR) needs at least 10 votes (approvals) from @rust-embedded/all
to be accepted. After the proposal has been accepted we'll proceed to implement
it.
@rust-embedded/all please vote on this proposal using pull request reviews.
Or if you have a concern leave a comment.
closes #171