Set type when purposely discarding return type #1202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raised by rust-lang/rust-clippy#6841, as it is safer in case of refactoring
kraktus
changed the title
|
Thanks for the PR! I would prefer to not include too many style suggestions in the reference. There are too many guidelines to add here, and there is not a specific process for deciding guidelines on how Rust code should be written. Something like this would probably be better served in something like clippy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised by rust-lang/rust-clippy#6841, as it is safer in case of refactoring.
It does not catch all, and for complex type return is probably not worth it in terms of readability but still think it's a good addition.
Wording can probably be improved.