-
Notifications
You must be signed in to change notification settings - Fork 1.4k
std::hash + collections::hashmap #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for commiting to this chapter!
Looks good to me.
Main focus should be usage, you could drop as a footnote: what hasher is used, and whether the hasher is crypto-secure or not. I don't think we should explain how the hasmap is implemented - we could drop a link to an explanation of the implementation, that the reader could follow if she wants to.
I'd love to see this. (There should be evidence that justifies the selection)
Sound like great examples. But the fact that one can't pass arguments to the executable via the live code editor may diminish their cool factor :-/ |
I have added the topics to the structure.json in my fork: abonander/rust-by-example@3997d87 Topics are subject to change as I am terrible with planning. |
Hi @cybergeek94, any update on this? Getting into |
I think I've pushed quite a bit to my fork (on mobile so can't link). If
|
Thanks! I'll take a look at your branch. |
If I want to link to the |
Right, thanks. I was hung up on Javadoc's
|
I fixed the mess in the I also finished |
I've been making many tiny commits, I didn't realize I had to squash them before pushing them so I will probably need to do some janitorial work before I can submit the pull request. |
I have submitted a pull request that closes this issue. Comments and suggestions are welcome. Edit: I see the Travis CI build has failed. I'll fix the errors. Edit 2: I don't see why it's failing now. There's no error message. |
I can work on these as I've had experience with hashmaps in the past, and I just completed a small project where I had to work out some nuances with hashmaps and lifetimes (I was trying to use references [specifically string slices] as keys).
Topics (
ref
is an arbitrary reference type, struct or enum):struct
s with#[deriving(Eq, Hash)]
HashSet<ref>
SmallIntMap<ref>
Not sure whether I should go into the underlying implementation of a common hashmap or just how to use it. Maybe compare
HashMap<int, int/ref>
toVec<int/ref>
and why one would prefer one over the other, and then introduceSmallIntMap<ref>
as a specialized alternative. I could present my use case for Hashmaps, an RPN calculator with user-defined variables, or maybe a basic memoizer app (setting values to keys via CLI and retrieving).The text was updated successfully, but these errors were encountered: