Skip to content

from_over_into: suggest a correct conversion to () #12141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

samueltardieu
Copy link
Contributor

changelog: [from_over_into]: suggest a correct conversion to ()

Fix #12138

@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2024

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 13, 2024
@Jarcho
Copy link
Contributor

Jarcho commented Jan 15, 2024

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Jan 15, 2024

📌 Commit e025356 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 15, 2024

⌛ Testing commit e025356 with merge 9d9a5c3...

bors added a commit that referenced this pull request Jan 15, 2024
from_over_into: suggest a correct conversion to ()

changelog: [`from_over_into`]: suggest a correct conversion to `()`

Fix #12138
@bors
Copy link
Contributor

bors commented Jan 15, 2024

💔 Test failed - checks-action_test

@Jarcho
Copy link
Contributor

Jarcho commented Jan 15, 2024

@bors retry

@bors
Copy link
Contributor

bors commented Jan 15, 2024

⌛ Testing commit e025356 with merge d6ff2d2...

@bors
Copy link
Contributor

bors commented Jan 15, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing d6ff2d2 to master...

@bors bors merged commit d6ff2d2 into rust-lang:master Jan 15, 2024
@samueltardieu samueltardieu deleted the issue-12138 branch September 2, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::from_over_into produces incorrect suggested code for unit type
4 participants